fix(workspace): clear strict lint and test debt

examples/html_examples/src/main.rs

@@ -740,7 +740,13 @@ mod tests {
         assert!(html.contains("name=\"q\" value=\"ga\""));
         assert!(html.contains("Results for ga"));
         assert!(html.contains("Gamma"));
-        assert!(!html.contains("Alpha"));
+        assert_eq!(
+            search_results_for("ga")
+                .into_iter()
+                .map(|result| result.label)
+                .collect::<Vec<_>>(),
+            ["Gamma"]
+        );
     }
 
     #[test]

examples/techdemo/tests/browser_e2e.rs

@@ -74,7 +74,7 @@ async fn browser_drives_typed_product_end_to_end() -> WebDriverResult<()> {
         .await?;
 
         driver
-            .find(By::Css(&handle_selector(simulate_push)))
+            .find(By::Css(handle_selector(simulate_push)))
             .await?
             .click()
             .await?;
@@ -82,7 +82,7 @@ async fn browser_drives_typed_product_end_to_end() -> WebDriverResult<()> {
         wait_for_text(&driver, island_readout_selector(), "activity rows").await?;
 
         driver
-            .find(By::Css(&handle_button_selector(launch_work)))
+            .find(By::Css(handle_button_selector(launch_work)))
             .await?
             .click()
             .await?;
@@ -95,14 +95,14 @@ async fn browser_drives_typed_product_end_to_end() -> WebDriverResult<()> {
         assert_text(&driver, "width:77%").await?;
 
         driver
-            .find(By::Css(&handle_selector(simulate_push)))
+            .find(By::Css(handle_selector(simulate_push)))
             .await?
             .click()
             .await?;
         wait_for_text(&driver, &target_selector(control::live_feed), "SSE tick").await?;
 
         driver
-            .find(By::Css(&nav_link_selector("/architecture")))
+            .find(By::Css(nav_link_selector("/architecture")))
             .await?
             .click()
             .await?;

examples/techdemo/tests/e2e.rs

@@ -28,7 +28,7 @@ struct Server {
 impl Server {
     fn start() -> Self {
         let bin = env!("CARGO_BIN_EXE_hemx-techdemo");
-        let child = Command::new(bin)
+        let mut child = Command::new(bin)
             .stdout(Stdio::null())
             .stderr(Stdio::null())
             .spawn()
@@ -41,6 +41,8 @@ impl Server {
             }
             std::thread::sleep(Duration::from_millis(25));
         }
+        let _ = child.kill();
+        let _ = child.wait();
         panic!("hemx-techdemo did not listen on {ADDR}");
     }
 }
@@ -379,7 +381,7 @@ fn assert_card(batch: &EffectInspector, title: &str, lane: &str, stage: &str, im
     let board = batch
         .target_html_containing(control::board, "class=\"lanes\"")
         .expect("board html payload");
-    let document = Html::parse_fragment(&board);
+    let document = Html::parse_fragment(board);
     let lane_selector = Selector::parse(&class_selector("lane")).unwrap();
     let card_selector = Selector::parse(&class_selector("work-card")).unwrap();
     let strong_selector = Selector::parse(strong_text_selector()).unwrap();

examples/workout/tests/browser_e2e.rs

@@ -75,7 +75,7 @@ async fn browser_proves_phone_first_workout_flow() -> WebDriverResult<()> {
         wait_for_body_text(&driver, "Undid: started Goblet squat set 2").await?;
 
         let host_panel = driver.find(By::Css(".host-proof")).await?;
-        assert!(!host_panel.attr("open").await?.is_some());
+        assert!(host_panel.attr("open").await?.is_none());
 
         driver.set_window_rect(0, 0, 1024, 900).await?;
         assert_viewport(&driver, "wide", false).await?;

examples/workout/tests/e2e.rs

@@ -18,7 +18,7 @@ impl Server {
         drop(listener);
 
         let bin = env!("CARGO_BIN_EXE_hemx-workout-example");
-        let child = Command::new(bin)
+        let mut child = Command::new(bin)
             .env("HEMX_WORKOUT_ADDR", &addr)
             .stdout(Stdio::null())
             .stderr(Stdio::null())
@@ -32,6 +32,8 @@ impl Server {
             }
             std::thread::sleep(Duration::from_millis(25));
         }
+        let _ = child.kill();
+        let _ = child.wait();
         panic!("hemx-workout-example did not listen on {addr}");
     }
 }