tmk241/hemx
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(kanban): recover malformed commands

Browse Source 
req: sync/015
This commit is contained in:
slhx agent
2026-07-13 15:15:40 +02:00
parent 47715e3ba3
commit 54b706b706
3 changed files with 162 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
hemx-wasm/tests/browser.rs
+141 -1
View File
@@ -585,7 +585,10 @@ async fn kanban_persistence_failure_does_not_project_and_recovers() -> WebDriver
.json()
.clone();
assert_eq!(failed["order"], "2|1");
assert_eq!(failed["notice"], "Moved 1 with click");
assert_eq!(
failed["notice"],
"Local command persist failed (ConstraintError). Recovery controls remain available."
);
assert_eq!(failed["count"], "1");
assert_eq!(failed["stage"], "persist");
assert_eq!(failed["code"], "ConstraintError");
@@ -633,6 +636,107 @@ async fn kanban_persistence_failure_does_not_project_and_recovers() -> WebDriver
result.and(quit)
}
#[tokio::test]
async fn kanban_corrupt_command_refuses_projection_and_recovers() -> WebDriverResult<()> {
// test req: sync/015
let workspace = PathBuf::from(env!("CARGO_MANIFEST_DIR"))
.parent()
.expect("workspace root")
.to_owned();
let (package, bootstrap, rendered) = build_kanban_artifact(&workspace);
let runtime = workspace.join("hemx-js/runtime/hemx.js");
let server = StaticServer::start(
package,
runtime,
bootstrap,
rendered,
"kanban_client",
Some(kanban_app_assets(&workspace)),
);
let webdriver_port = available_port();
let webdriver_addr = format!("127.0.0.1:{webdriver_port}");
let mut webdriver = Command::new("geckodriver");
webdriver.arg("--port").arg(webdriver_port.to_string());
let _webdriver = ProcessGuard::start(webdriver, &webdriver_addr);
let mut caps = DesiredCapabilities::firefox();
caps.set_headless()?;
let driver = WebDriver::new(&format!("http://{webdriver_addr}"), caps).await?;
let result = async {
driver.goto(&server.url()).await?;
wait_until(
&driver,
"const root = document.querySelector('[data-hemx-root]'); return root.hasAttribute('data-kanban-command-ready') && root.hasAttribute('data-kanban-offline-ready')",
)
.await?;
store_malformed_command(&driver).await?;
driver
.execute("window.__reloadPending = true; location.reload()", Vec::new())
.await?;
wait_until(
&driver,
"const root = document.querySelector('[data-hemx-root]'); return !window.__reloadPending && root.hasAttribute('data-kanban-command-error')",
)
.await?;
let refused = driver
.execute(
"const root = document.querySelector('[data-hemx-root]'); return { order: [...root.querySelectorAll('[data-key]')].map((node) => node.dataset.key).join('|'), ready: root.hasAttribute('data-kanban-command-ready'), error: root.getAttribute('data-kanban-command-error'), stage: root.getAttribute('data-kanban-command-error-stage'), code: root.getAttribute('data-kanban-command-error-code'), notice: root.querySelector('[role=status]').textContent }",
Vec::new(),
)
.await?
.json()
.clone();
assert_eq!(refused["order"], "1|2");
assert_eq!(refused["ready"], false);
assert_eq!(
refused["error"],
"restore: invalid durable command corrupt:1: cardId"
);
assert_eq!(refused["stage"], "restore");
assert_eq!(refused["code"], "Error");
assert_eq!(
refused["notice"],
"Local command restore failed (Error). Recovery controls remain available."
);
let recovery_export = export_commands(&driver).await?.json().clone();
assert_eq!(recovery_export["schemaVersion"], 1);
assert_eq!(recovery_export["commands"].as_array().map(Vec::len), Some(1));
assert_eq!(recovery_export["commands"][0]["id"], "corrupt:1");
assert_eq!(recovery_export["commands"][0]["cardId"], "");
driver
.execute("window.__reloadPending = true", Vec::new())
.await?;
let delete = driver
.find(By::Css("[data-kanban-command-action='delete']"))
.await?;
delete.click().await?;
delete.click().await?;
wait_until(
&driver,
"const root = document.querySelector('[data-hemx-root]'); return !window.__reloadPending && root.hasAttribute('data-kanban-command-ready') && root.getAttribute('data-kanban-command-count') === '0'",
)
.await?;
let recovered = driver
.execute(
"const root = document.querySelector('[data-hemx-root]'); return { order: [...root.querySelectorAll('[data-key]')].map((node) => node.dataset.key).join('|'), error: root.getAttribute('data-kanban-command-error') }",
Vec::new(),
)
.await?
.json()
.clone();
assert_eq!(recovered["order"], "1|2");
assert!(recovered["error"].is_null());
let empty_export = export_commands(&driver).await?.json().clone();
assert_eq!(empty_export["commands"].as_array().map(Vec::len), Some(0));
Ok(())
}
.await;
let quit = driver.quit().await;
result.and(quit)
}
#[tokio::test]
async fn kanban_reorder_has_pointer_keyboard_focus_and_reduced_motion_parity() -> WebDriverResult<()>
{
@@ -1044,6 +1148,42 @@ fn fixture_html(rendered: &str, has_app_module: bool) -> String {
)
}
async fn store_malformed_command(driver: &WebDriver) -> WebDriverResult<()> {
let stored = driver
.execute_async(
r#"
const done = arguments[arguments.length - 1];
const open = indexedDB.open('hemx-kanban-v1', 1);
open.onerror = () => done({ error: open.error && open.error.name });
open.onsuccess = () => {
const tx = open.result.transaction('commands', 'readwrite');
tx.objectStore('commands').add({
id: 'corrupt:1',
schemaVersion: 1,
actor: 'corrupt',
session: 'corrupt',
causal: 1,
kind: 'reorder_card',
cardId: '',
eventKind: 'click',
key: null,
});
tx.oncomplete = () => done({ stored: true });
tx.onabort = () => done({ error: tx.error && tx.error.name });
};
"#,
Vec::new(),
)
.await?
.json()
.clone();
assert_eq!(
stored["stored"], true,
"failed to store malformed command: {stored}"
);
Ok(())
}
async fn occupy_next_command_id(driver: &WebDriver) -> WebDriverResult<()> {
let occupied = driver
.execute_async(